wkitty42
15th of February 2007 (Thu), 10:19
pekka,
i seem to have found a bit of a "bug" on the index page... i'm using the "Grey w/ Horizontal Sort" templates for all my exhibits... i'm also using groups and have them displayed on the index page... here's a short section of code from the browser showing the problem...
from {galleryroot}/index.php<div class="ee_group_plate">
<h3 class="ee_group_name ee_css_header_small">
<a href="index.php?groupid=4&ee_lang=eng"><img src="./graphs/folder1.gif" style="border: 0px; border-style: none;" alt="" /></a>
<a href ="index.php?groupid=4&ee_lang=eng" title="Exhibits of pictures and documentaries that Waldo has taken over the years.">Waldo's Exhibits</a> </h3>
<div class="ee_group_itemcount ee_css_paragraph_small">
16 galleries </div>
<div class="ee_group_image">
<a href="index.php?groupid=4&ee_lang=eng"><a href ="index.php?groupid=4&ee_lang=eng">
<img src="./graphs/whitecat3.png" alt="Waldo's Exhibits" border="" hspace="8" style="border-color: #;"></a></a>[chomp urls to microthumbs] </div>
</div>
the problem is the two "a href"'s in the ee_group_image div... there should only be one since they are identical... same for the ending "/a"...
the best fix appears to be the following...
in {galleryroot}/templates/pages/ee_2_default/group/embedded/default_XHTML_content.php, find on or about line 34 (in the released v2.02 code)
<div class="ee_group_image">
<a href="index.php?groupid=<?php print $linked_group; ?>&ee_lang=<?php print $ee_lang; ?>"><?php print $group_image_html; print "</a>"; print $group_thumbs_html; ?>
</div>
and replace it with
<div class="ee_group_image">
<?php print $group_image_html; print $group_thumbs_html; ?>
</div>
the extraneous output doesn't cause a problem that i'm aware of but it looks messy (to those of us who look at html source :wink: )...
analysis shows that this duplication comes from the code being in two places... first in {galleryroot}/index.php and second in the embedded {galleryroot}/templates/pages/ee_2_default/group/embedded/default_XHTML_content.php. this problem does not appear in the ee_2_default_UDM code...
the above fix also eliminates the empty hrefs on groups that do not have a groupimage defined... that's what i like! killing two birds with one stone :wink:
i'm posting this here so that you can include it in the next round of bugfixes... especially since i lost numerous fixes i had done in v2.01 because i thought you had included them in v2.02... one being to detect the user's browser and version to avoid emitting the "<?xml version="1.0" encoding="iso-8859-1"?>" line to certain IEs and whatever other browsers have a problem with it...
i seem to have found a bit of a "bug" on the index page... i'm using the "Grey w/ Horizontal Sort" templates for all my exhibits... i'm also using groups and have them displayed on the index page... here's a short section of code from the browser showing the problem...
from {galleryroot}/index.php<div class="ee_group_plate">
<h3 class="ee_group_name ee_css_header_small">
<a href="index.php?groupid=4&ee_lang=eng"><img src="./graphs/folder1.gif" style="border: 0px; border-style: none;" alt="" /></a>
<a href ="index.php?groupid=4&ee_lang=eng" title="Exhibits of pictures and documentaries that Waldo has taken over the years.">Waldo's Exhibits</a> </h3>
<div class="ee_group_itemcount ee_css_paragraph_small">
16 galleries </div>
<div class="ee_group_image">
<a href="index.php?groupid=4&ee_lang=eng"><a href ="index.php?groupid=4&ee_lang=eng">
<img src="./graphs/whitecat3.png" alt="Waldo's Exhibits" border="" hspace="8" style="border-color: #;"></a></a>[chomp urls to microthumbs] </div>
</div>
the problem is the two "a href"'s in the ee_group_image div... there should only be one since they are identical... same for the ending "/a"...
the best fix appears to be the following...
in {galleryroot}/templates/pages/ee_2_default/group/embedded/default_XHTML_content.php, find on or about line 34 (in the released v2.02 code)
<div class="ee_group_image">
<a href="index.php?groupid=<?php print $linked_group; ?>&ee_lang=<?php print $ee_lang; ?>"><?php print $group_image_html; print "</a>"; print $group_thumbs_html; ?>
</div>
and replace it with
<div class="ee_group_image">
<?php print $group_image_html; print $group_thumbs_html; ?>
</div>
the extraneous output doesn't cause a problem that i'm aware of but it looks messy (to those of us who look at html source :wink: )...
analysis shows that this duplication comes from the code being in two places... first in {galleryroot}/index.php and second in the embedded {galleryroot}/templates/pages/ee_2_default/group/embedded/default_XHTML_content.php. this problem does not appear in the ee_2_default_UDM code...
the above fix also eliminates the empty hrefs on groups that do not have a groupimage defined... that's what i like! killing two birds with one stone :wink:
i'm posting this here so that you can include it in the next round of bugfixes... especially since i lost numerous fixes i had done in v2.01 because i thought you had included them in v2.02... one being to detect the user's browser and version to avoid emitting the "<?xml version="1.0" encoding="iso-8859-1"?>" line to certain IEs and whatever other browsers have a problem with it...