I am in the process of adding a third lens to my collection. I consider myself of an amateur/enthusiast skill-level; I know what most of the control settings do and I shoot RAW. The equipment I currently have:
Canon Digital Rebel XS body
Canon EF-S 18-55mm IS
Tamron 75-700mm LD
I primarily take wildlife, nature/landscape and night sky (stars, moon, etc) pictures. I am very pleased with the image quality I get from the 18-55mm; I went to Yellowstone last summer and got some stunning wide-angle pictures of the upper and lower falls. I am going to Shenandoah National Park this summer, which should offer some similar wide vistas and lots of wildlife.
The 75-300mm doesn't take very nice pictures. Everything I take is not crisp; even in ideal lighting on a tripod I end up with a "soft focused" picture. Regardless of the lighting every single picture is either over-exposed or under-exposed, even when my light meter says my exposure is correct.
I'm think I'm looking for a general purpose lens, but at the same time I'm not sure. I am not willing to consider non-Canon lenses at the moment because of my experience with Tamron. I considering the Canon 28-135mm IS USM for general purpose, but a lot of reviews say its not quite wide enough on a APS-C sensor camera. I am also considering the EF 50mm II prime, but it also seems like too much zoom with an APS-C sensor.
I am seeking advice/suggestions on the above two lenses, or anything else anyone thinks is essential to a lens collection. Any advice is welcome. My budget maxes out at $450, which means I'm keeping this to the EF and EF-S lines, no L's for me yet.
I've picked up a Tamron 70-300mm VC USD and it is an excellent lens, but given the prices for 55-250mm (I see used copies @ $150! here from time to time) I recommend you get one of those and use the remaining money for a prime or a UWA lens.
