Canon 28-135mmf3.5/5.6 IS USM

would this be ok for general landscape work?

...eh. Best way would be to try, I suppose. I was far from impressed with image quality, though.

I don't think that the 28-135mm IS USM is wide enough for Landscapes. If you can afford it, go for the Canon 17-40L or the Tamron 17-35mm for about $250 less.

For ultra wide shots, many here like the Tokina 12-24 f4. My brother has the Canon 10-22mm EF-S and it appears to be very, very, very nice.

The 28-135 IS is quite soft between 28-40mm, especially wide open (F3.5) so it's not the greatest landscape lens but if you're on a budget it'll make a good walkaround lens.

The Canon 17-40L would be ideal or if you need longer focal length the 17-85 EF-S is worth looking at.

Ron, you're such a wag! When you had one it was the best thing since sliced bread

But you're right. It's Ok if you want the range and IS, but optically there are better choices. Doesn't mean you can't get some very decent shots. For landscape tho' I'd absolutely look at something else. Usual suspects have been mentioned above. I made my choice and happy with it.

thanks for the info have to have a rethink and consult SHMBO